Electric-Special/ha-core
1
0
Fork 0
mirror of https://github.com/Electric-Special/ha-core.git synced 2026-03-21 04:05:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Enforce namespace use for import conventions (#118215)

Browse Source 
* Enforce namespace use for import conventions

* Include all registries

* Only apply to functions

* Use blacklist

* Rephrase comment

* Add async_entries_for_config_entry

* Typo

* Improve

* More core files

* Revert "More core files"

This reverts commit 9978b9370629af402a9a18f184b6f3a7ad45b08d.

* Revert diagnostics amends

* Include category/floor/label registries

* Performance

* Adjust text
This commit is contained in:
epenet
2024-05-28 18:15:53 +02:00
committed by GitHub
parent 14132b5090
commit 05fc7cfbde
2 changed files with 109 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

57
tests/pylint/test_imports.py
View File

@@ -252,3 +252,60 @@ def test_bad_root_import(
imports_checker.visit_import(node)
if import_node.startswith("from"):
imports_checker.visit_importfrom(node)
@pytest.mark.parametrize(
("import_node", "module_name", "expected_args"),
[
(
"from homeassistant.helpers.issue_registry import async_get",
"tests.components.pylint_test.climate",
(
"async_get",
"homeassistant.helpers.issue_registry",
"ir",
"ir",
"async_get",
),
),
(
"from homeassistant.helpers.issue_registry import async_get as async_get_issue_registry",
"tests.components.pylint_test.climate",
(
"async_get",
"homeassistant.helpers.issue_registry",
"ir",
"ir",
"async_get",
),
),
],
)
def test_bad_namespace_import(
linter: UnittestLinter,
imports_checker: BaseChecker,
import_node: str,
module_name: str,
expected_args: tuple[str, ...],
) -> None:
"""Ensure bad namespace imports are rejected."""
node = astroid.extract_node(
f"{import_node} #@",
module_name,
)
imports_checker.visit_module(node.parent)
with assert_adds_messages(
linter,
pylint.testutils.MessageTest(
msg_id="hass-helper-namespace-import",
node=node,
args=expected_args,
line=1,
col_offset=0,
end_line=1,
end_col_offset=len(import_node),
),
):
imports_checker.visit_importfrom(node)