diff --git a/CODEOWNERS b/CODEOWNERS index 81bf82240c8..5bffc7856f9 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -183,8 +183,8 @@ build.json @home-assistant/supervisor /homeassistant/components/automation/ @home-assistant/core /tests/components/automation/ @home-assistant/core /homeassistant/components/avea/ @pattyland -/homeassistant/components/awair/ @ahayworth @danielsjf -/tests/components/awair/ @ahayworth @danielsjf +/homeassistant/components/awair/ @ahayworth @ricohageman +/tests/components/awair/ @ahayworth @ricohageman /homeassistant/components/aws_s3/ @tomasbedrich /tests/components/aws_s3/ @tomasbedrich /homeassistant/components/axis/ @Kane610 diff --git a/homeassistant/components/awair/manifest.json b/homeassistant/components/awair/manifest.json index 1ec10bfa8a2..376d66d4cc3 100644 --- a/homeassistant/components/awair/manifest.json +++ b/homeassistant/components/awair/manifest.json @@ -1,7 +1,7 @@ { "domain": "awair", "name": "Awair", - "codeowners": ["@ahayworth", "@danielsjf"], + "codeowners": ["@ahayworth", "@ricohageman"], "config_flow": true, "documentation": "https://www.home-assistant.io/integrations/awair", "iot_class": "local_polling", diff --git a/homeassistant/components/awair/quality_scale.yaml b/homeassistant/components/awair/quality_scale.yaml new file mode 100644 index 00000000000..9467e8acdd2 --- /dev/null +++ b/homeassistant/components/awair/quality_scale.yaml @@ -0,0 +1,98 @@ +rules: + # Bronze + action-setup: + status: exempt + comment: No actions defined + appropriate-polling: + status: done + comment: | + We fetch both user and devices, could probably slow one down + brands: done + common-modules: done + config-flow: + status: todo + comment: | + data_description fields are missing + Should not abort in cloud step when anything else than invalid access token + Find out why access token is optional + Discovered devices step is redundant + config-flow-test-coverage: + status: todo + comment: | + Move happy flow to the top and merge with `test_show_form` + Reuse `result` + Cloud tests should initialize with data directly + Tests should finish in CREATE_ENTRY + dependency-transparency: + status: todo + comment: | + Dependency is not built in the CI + docs-actions: todo + docs-high-level-description: done + docs-installation-instructions: done + docs-removal-instructions: done + entity-event-setup: + status: exempt + comment: No explicit event subscription + entity-unique-id: done + has-entity-name: done + runtime-data: done + test-before-configure: done + test-before-setup: done + unique-config-entry: done + + # Silver + action-exceptions: + status: exempt + comment: No actions defined + config-entry-unloading: done + docs-configuration-parameters: todo + docs-installation-parameters: todo + entity-unavailable: todo + integration-owner: done + log-when-unavailable: done + parallel-updates: todo + reauthentication-flow: done + test-coverage: + status: todo + comment: | + Patch objects where we use them + Use test helpers to load JSON + typo `no_devicess_fixture` + Make common config entries for cloud and local + Test setup of the integration + + # Gold + devices: + status: done + comment: | + Can move to shorthand attribute + Can remove typecast + diagnostics: todo + discovery: done + discovery-update-info: done + docs-data-update: done + docs-examples: todo + docs-known-limitations: todo + docs-supported-devices: todo + docs-supported-functions: todo + docs-troubleshooting: todo + docs-use-cases: todo + dynamic-devices: todo + entity-category: todo + entity-device-class: + status: done + comment: | + Can remove rounding + entity-disabled-by-default: done + entity-translations: done + exception-translations: todo + icon-translations: done + reconfiguration-flow: todo + repair-issues: todo + stale-devices: todo + + # Platinum + async-dependency: todo + inject-websession: done + strict-typing: todo diff --git a/script/hassfest/quality_scale.py b/script/hassfest/quality_scale.py index b91a8264bd7..230384b4c1c 100644 --- a/script/hassfest/quality_scale.py +++ b/script/hassfest/quality_scale.py @@ -186,7 +186,6 @@ INTEGRATIONS_WITHOUT_QUALITY_SCALE_FILE = [ "aussie_broadband", "avea", "avion", - "awair", "aws", "axis", "azure_data_explorer",