starred/OpenEPaperLink
1
0
Fork 0
mirror of https://github.com/OpenEPaperLink/OpenEPaperLink.git synced 2026-03-21 00:04:28 +01:00
Code Issues 472 Packages Projects Releases 10 Wiki Activity

[PR #210] [MERGED] Pending queue #1008

New Issue
Closed
opened 2026-03-20 18:14:50 +01:00 by sascha_hemi · 0 comments
sascha_hemi commented 2026-03-20 18:14:50 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/OpenEPaperLink/OpenEPaperLink/pull/210
Author: @nlimper
Created: 1/25/2024
Status: ✅ Merged
Merged: 1/29/2024
Merged by: @nlimper

Base: master ← Head: pending-queue

📝 Commits (9)

📊 Changes

26 files changed (+354 additions, -212 deletions)

View changed files

📝 ESP32_AP-Flasher/data/tagtypes/31.json (+1 -1)
📝 ESP32_AP-Flasher/data/www/edit.html.gz (+0 -0)
📝 ESP32_AP-Flasher/data/www/index.html.gz (+0 -0)
📝 ESP32_AP-Flasher/data/www/main.css.gz (+0 -0)
📝 ESP32_AP-Flasher/data/www/main.js.gz (+0 -0)
📝 ESP32_AP-Flasher/include/commstructs.h (+9 -4)
📝 ESP32_AP-Flasher/include/newproto.h (+20 -0)
📝 ESP32_AP-Flasher/include/serialap.h (+2 -2)
📝 ESP32_AP-Flasher/include/tag_db.h (+2 -3)
📝 ESP32_AP-Flasher/include/tagdata.h (+5 -1)
📝 ESP32_AP-Flasher/platformio.ini (+3 -0)
📝 ESP32_AP-Flasher/src/contentmanager.cpp (+2 -8)
📝 ESP32_AP-Flasher/src/flasher.cpp (+2 -2)
📝 ESP32_AP-Flasher/src/ips_display.cpp (+1 -1)
📝 ESP32_AP-Flasher/src/main.cpp (+4 -0)
📝 ESP32_AP-Flasher/src/makeimage.cpp (+0 -2)
📝 ESP32_AP-Flasher/src/newproto.cpp (+221 -101)
📝 ESP32_AP-Flasher/src/serialap.cpp (+13 -17)
📝 ESP32_AP-Flasher/src/storage.cpp (+0 -1)
📝 ESP32_AP-Flasher/src/tag_db.cpp (+2 -7)

...and 6 more files

📄 Description

Pretty complex change here: pending images/commands are now queued.

A command (like LED flasher) will not overwrite a pending image anymore. Also, sending multiple preloaded images is possible.
Also works (at least, as far as I could test) in combination with Multi AP and mirroring tags ('display a copy' content type).

It you want to test this: don't forget to upload the changed files in /www (the pending icon is now displaying the amount of queued messages). Timing improvements will follow later (only one message can be transmitted every checkin. If multiple messages are queued, at this moment, you have to wait until the next checkin which takes 40-60 sec).

This comes also with the advantage of better stability if you upload multiple images to the same tag in succession. Before queuing, if was possible to replace the image between sending the pending message and the image transfer to the tag, causing md5 mismatches and instability.

Solves https://github.com/jjwbruijn/OpenEPaperLink/issues/47

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/OpenEPaperLink/OpenEPaperLink/pull/210 **Author:** [@nlimper](https://github.com/nlimper) **Created:** 1/25/2024 **Status:** ✅ Merged **Merged:** 1/29/2024 **Merged by:** [@nlimper](https://github.com/nlimper) **Base:** `master` ← **Head:** `pending-queue` --- ### 📝 Commits (9) - [`a0221c9`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/a0221c9ee452d47120d53066da9eec92f98f98d5) work in progress - [`733d0a0`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/733d0a0dc76015b8fb998324242d60c16cd5bcc6) work in progress - [`9b9ef53`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/9b9ef5345ee932e6aa3acedecf3b92004861b8c7) work in progress - [`c67e6e7`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/c67e6e7fabe905c0807a55547293d4c6e6460c8c) Merge branch 'master' into pending-queue - [`2c8aee7`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/2c8aee7a5a6962e4717ee93ed239f02839bb19ae) pending queue + javascript timings - [`4f13f25`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/4f13f251667240cea6ec09ad03f7be7183fc5ec7) external tag fetch image - [`3ace740`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/3ace74001d7df102912f54d3c5720feb6961e752) Update tagdata.cpp - [`d276867`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/d27686799f3e0972f55243225701cb884f31c905) last fixes - [`dea6f76`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/dea6f7667048e0513438665e7691725f114df381) Merge branch 'master' into pending-queue ### 📊 Changes **26 files changed** (+354 additions, -212 deletions) <details> <summary>View changed files</summary> 📝 `ESP32_AP-Flasher/data/tagtypes/31.json` (+1 -1) 📝 `ESP32_AP-Flasher/data/www/edit.html.gz` (+0 -0) 📝 `ESP32_AP-Flasher/data/www/index.html.gz` (+0 -0) 📝 `ESP32_AP-Flasher/data/www/main.css.gz` (+0 -0) 📝 `ESP32_AP-Flasher/data/www/main.js.gz` (+0 -0) 📝 `ESP32_AP-Flasher/include/commstructs.h` (+9 -4) 📝 `ESP32_AP-Flasher/include/newproto.h` (+20 -0) 📝 `ESP32_AP-Flasher/include/serialap.h` (+2 -2) 📝 `ESP32_AP-Flasher/include/tag_db.h` (+2 -3) 📝 `ESP32_AP-Flasher/include/tagdata.h` (+5 -1) 📝 `ESP32_AP-Flasher/platformio.ini` (+3 -0) 📝 `ESP32_AP-Flasher/src/contentmanager.cpp` (+2 -8) 📝 `ESP32_AP-Flasher/src/flasher.cpp` (+2 -2) 📝 `ESP32_AP-Flasher/src/ips_display.cpp` (+1 -1) 📝 `ESP32_AP-Flasher/src/main.cpp` (+4 -0) 📝 `ESP32_AP-Flasher/src/makeimage.cpp` (+0 -2) 📝 `ESP32_AP-Flasher/src/newproto.cpp` (+221 -101) 📝 `ESP32_AP-Flasher/src/serialap.cpp` (+13 -17) 📝 `ESP32_AP-Flasher/src/storage.cpp` (+0 -1) 📝 `ESP32_AP-Flasher/src/tag_db.cpp` (+2 -7) _...and 6 more files_ </details> ### 📄 Description Pretty complex change here: pending images/commands are now queued. A command (like LED flasher) will not overwrite a pending image anymore. Also, sending multiple preloaded images is possible. Also works (at least, as far as I could test) in combination with Multi AP and mirroring tags ('display a copy' content type). It you want to test this: don't forget to upload the changed files in /www (the pending icon is now displaying the amount of queued messages). Timing improvements will follow later (only one message can be transmitted every checkin. If multiple messages are queued, at this moment, you have to wait until the next checkin which takes 40-60 sec). This comes also with the advantage of better stability if you upload multiple images to the same tag in succession. Before queuing, if was possible to replace the image between sending the pending message and the image transfer to the tag, causing md5 mismatches and instability. Solves https://github.com/jjwbruijn/OpenEPaperLink/issues/47 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
sascha_hemi added the pull-request label 2026-03-20 18:14:50 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
88MZ100 FW
ARM Tag FW
ap fw
bug
documentation
enhancement
good first issue
nRF FW
pull-request
Mirrored from GitHub Pull Request
 question
tag fw
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
sascha_hemi
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/OpenEPaperLink#1008
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?