starred/OpenEPaperLink
1
0
Fork 0
mirror of https://github.com/OpenEPaperLink/OpenEPaperLink.git synced 2026-03-21 00:04:28 +01:00
Code Issues 472 Packages Projects Releases 10 Wiki Activity

[PR #419] [CLOSED] fix redirect for remote image url #2182

New Issue
Closed
opened 2026-03-20 20:09:11 +01:00 by sascha_hemi · 0 comments
sascha_hemi commented 2026-03-20 20:09:11 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/OpenEPaperLink/OpenEPaperLink/pull/419
Author: @RoCry
Created: 12/23/2024
Status: ❌ Closed

Base: master ← Head: fix-img-url-redirect

📝 Commits (1)

  • 82fcf8b handles 301 and 302 redirect for remote image url

📊 Changes

1 file changed (+54 additions, -25 deletions)

View changed files

📝 ESP32_AP-Flasher/src/contentmanager.cpp (+54 -25)

📄 Description

the content type image url doesn't handle redirects correctly

changes:

  1. setFollowRedirects HTTPC_STRICT_FOLLOW_REDIRECTS
  2. try get location from Location or location
  3. follow max to 5 redirects

test with: https://github.com/RoCry/epd-image-action/releases/download/latest/urbandictionary_400x300.jpg
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/OpenEPaperLink/OpenEPaperLink/pull/419 **Author:** [@RoCry](https://github.com/RoCry) **Created:** 12/23/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-img-url-redirect` --- ### 📝 Commits (1) - [`82fcf8b`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/82fcf8bcc0af8c632900fae6e0d56402e7f744c2) handles 301 and 302 redirect for remote image url ### 📊 Changes **1 file changed** (+54 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `ESP32_AP-Flasher/src/contentmanager.cpp` (+54 -25) </details> ### 📄 Description the content type image url doesn't handle redirects correctly changes: 1. `setFollowRedirects HTTPC_STRICT_FOLLOW_REDIRECTS` 2. try get location from `Location` or `location` 3. follow max to 5 redirects test with: https://github.com/RoCry/epd-image-action/releases/download/latest/urbandictionary_400x300.jpg <img width="906" alt="image" src="https://github.com/user-attachments/assets/17a35f58-b7ff-4c13-bcfa-13bd54e5475f" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
sascha_hemi added the pull-request label 2026-03-20 20:09:11 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
88MZ100 FW
ARM Tag FW
ap fw
bug
documentation
enhancement
good first issue
nRF FW
pull-request
Mirrored from GitHub Pull Request
 question
tag fw
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
sascha_hemi
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/OpenEPaperLink#2182
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?