[PR #309] [MERGED] Consolidate serial output to \r\n #3251

New Issue

sascha_hemi · 2026-03-20T22:08:07+01:00

sascha_hemi commented

2026-03-20 22:08:07 +01:00

📋 Pull Request Information

Original PR: https://github.com/OpenEPaperLink/OpenEPaperLink/pull/309
Author: @dm8tbr
Created: 5/4/2024
Status: ✅ Merged
Merged: 5/10/2024
Merged by: @jonasniesner

Base: master ← Head: serial-cleanup

📝 Commits (2)

2576fe8 Consolidate serial output to \r\n
cb48bf1 Merge branch 'jjwbruijn:master' into serial-cleanup

📊 Changes

16 files changed (+145 additions, -145 deletions)

View changed files

📝 ESP32_AP-Flasher/include/util.h (+2 -2)
📝 ESP32_AP-Flasher/src/ble_filter.cpp (+2 -2)
📝 ESP32_AP-Flasher/src/contentmanager.cpp (+1 -1)
📝 ESP32_AP-Flasher/src/flasher.cpp (+32 -32)
📝 ESP32_AP-Flasher/src/ips_display.cpp (+1 -1)
📝 ESP32_AP-Flasher/src/main.cpp (+2 -2)
📝 ESP32_AP-Flasher/src/makeimage.cpp (+1 -1)
📝 ESP32_AP-Flasher/src/newproto.cpp (+22 -22)
📝 ESP32_AP-Flasher/src/serialap.cpp (+47 -47)
📝 ESP32_AP-Flasher/src/storage.cpp (+1 -1)
📝 ESP32_AP-Flasher/src/swd.cpp (+4 -4)
📝 ESP32_AP-Flasher/src/tag_db.cpp (+1 -1)
📝 ESP32_AP-Flasher/src/tagdata.cpp (+4 -4)
📝 ESP32_AP-Flasher/src/usbflasher.cpp (+17 -17)
📝 ESP32_AP-Flasher/src/web.cpp (+2 -2)
📝 ESP32_AP-Flasher/src/webflasher.cpp (+6 -6)

📄 Description

So far the serial output is a mix of \r\n for println() and \n for sprintf() and such.
This commit consolidates this to a consistent \r\n.
There should be no noticeable difference for users of terminals that auto-substitute a sole \n to \r\n.
This will however make the serial output friendly to default behavior of various terminal emulators like 'screen' and 'minicom'.

This commit doesn't touch anything that is not serial output and also leaves 'ets_printf' alone just in case.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OpenEPaperLink/OpenEPaperLink/pull/309 **Author:** [@dm8tbr](https://github.com/dm8tbr) **Created:** 5/4/2024 **Status:** ✅ Merged **Merged:** 5/10/2024 **Merged by:** [@jonasniesner](https://github.com/jonasniesner) **Base:** `master` ← **Head:** `serial-cleanup` --- ### 📝 Commits (2) - [`2576fe8`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/2576fe834c44236abd40f516369d526c96911664) Consolidate serial output to \r\n - [`cb48bf1`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/cb48bf15fafa884333af8fcafe9adae584bd606f) Merge branch 'jjwbruijn:master' into serial-cleanup ### 📊 Changes **16 files changed** (+145 additions, -145 deletions) <details> <summary>View changed files</summary> 📝 `ESP32_AP-Flasher/include/util.h` (+2 -2) 📝 `ESP32_AP-Flasher/src/ble_filter.cpp` (+2 -2) 📝 `ESP32_AP-Flasher/src/contentmanager.cpp` (+1 -1) 📝 `ESP32_AP-Flasher/src/flasher.cpp` (+32 -32) 📝 `ESP32_AP-Flasher/src/ips_display.cpp` (+1 -1) 📝 `ESP32_AP-Flasher/src/main.cpp` (+2 -2) 📝 `ESP32_AP-Flasher/src/makeimage.cpp` (+1 -1) 📝 `ESP32_AP-Flasher/src/newproto.cpp` (+22 -22) 📝 `ESP32_AP-Flasher/src/serialap.cpp` (+47 -47) 📝 `ESP32_AP-Flasher/src/storage.cpp` (+1 -1) 📝 `ESP32_AP-Flasher/src/swd.cpp` (+4 -4) 📝 `ESP32_AP-Flasher/src/tag_db.cpp` (+1 -1) 📝 `ESP32_AP-Flasher/src/tagdata.cpp` (+4 -4) 📝 `ESP32_AP-Flasher/src/usbflasher.cpp` (+17 -17) 📝 `ESP32_AP-Flasher/src/web.cpp` (+2 -2) 📝 `ESP32_AP-Flasher/src/webflasher.cpp` (+6 -6) </details> ### 📄 Description So far the serial output is a mix of \r\n for println() and \n for sprintf() and such. This commit consolidates this to a consistent \r\n. There should be no noticeable difference for users of terminals that auto-substitute a sole \n to \r\n. This will however make the serial output friendly to default behavior of various terminal emulators like 'screen' and 'minicom'. This commit doesn't touch anything that is not serial output and also leaves 'ets_printf' alone just in case. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

sascha_hemi added the pull-request label 2026-03-20 22:08:07 +01:00

sascha_hemi closed this issue

2026-03-20 22:08:08 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/OpenEPaperLink#3251