[PR #112] [MERGED] Refactor contentmanager #3732

Closed
opened 2026-03-20 23:08:02 +01:00 by sascha_hemi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/OpenEPaperLink/OpenEPaperLink/pull/112
Author: @enwi
Created: 8/12/2023
Status: Merged
Merged: 8/12/2023
Merged by: @nlimper

Base: masterHead: esp32_ap


📝 Commits (10+)

  • b981a7f Start contentmanager cleanup
  • de8478d Refactor contentmanager::drawNew
  • 1225a28 Optimize contentManager::replaceVariables
  • 2994be4 Fix missing const in prepareCancelPending
  • f848b1c Refactor drawDate
  • de8cf3e Refactor drawWeather, drawForecast & getLocation
  • 9fb4a52 Add util function for printing largest free block
  • ef559dc Reuse weather icons for both drawWeather & drawForecast
  • 5d5566c Make httpGetJson timeout const
  • f6f90d7 Reafctor more functions

📊 Changes

12 files changed (+483 additions, -364 deletions)

View changed files

📝 ESP32_AP-Flasher/include/contentmanager.h (+12 -12)
📝 ESP32_AP-Flasher/include/newproto.h (+8 -8)
📝 ESP32_AP-Flasher/include/tag_db.h (+6 -7)
ESP32_AP-Flasher/include/util.h (+102 -0)
📝 ESP32_AP-Flasher/include/web.h (+2 -2)
📝 ESP32_AP-Flasher/src/contentmanager.cpp (+298 -279)
📝 ESP32_AP-Flasher/src/main.cpp (+14 -13)
📝 ESP32_AP-Flasher/src/makeimage.cpp (+4 -3)
📝 ESP32_AP-Flasher/src/newproto.cpp (+20 -20)
📝 ESP32_AP-Flasher/src/ota.cpp (+4 -8)
📝 ESP32_AP-Flasher/src/tag_db.cpp (+8 -8)
📝 ESP32_AP-Flasher/src/web.cpp (+5 -4)

📄 Description

No description provided


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/OpenEPaperLink/OpenEPaperLink/pull/112 **Author:** [@enwi](https://github.com/enwi) **Created:** 8/12/2023 **Status:** ✅ Merged **Merged:** 8/12/2023 **Merged by:** [@nlimper](https://github.com/nlimper) **Base:** `master` ← **Head:** `esp32_ap` --- ### 📝 Commits (10+) - [`b981a7f`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/b981a7f203a3205e6a63f2e40e319db4b658d310) Start contentmanager cleanup - [`de8478d`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/de8478d9fbea09d93b4da5fde6f4b14580d0365a) Refactor contentmanager::drawNew - [`1225a28`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/1225a28921574ea113510ab81e8e931ff933c0f1) Optimize contentManager::replaceVariables - [`2994be4`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/2994be4403c652e3d51817489ee3d048b19803e1) Fix missing const in prepareCancelPending - [`f848b1c`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/f848b1c677b99f1775738952a8964edd20a3e24f) Refactor drawDate - [`de8cf3e`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/de8cf3e30871db99f43771d64b8f86be02d854cd) Refactor drawWeather, drawForecast & getLocation - [`9fb4a52`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/9fb4a526fad74d41b6d7e13b39445104cd52a7af) Add util function for printing largest free block - [`ef559dc`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/ef559dcde3a131e65320d4fea6fd39f63905a1be) Reuse weather icons for both drawWeather & drawForecast - [`5d5566c`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/5d5566cc12d9b1e70f6cd5b7435648750e03ed93) Make httpGetJson timeout const - [`f6f90d7`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/f6f90d7e9be9e6c4aa4bed848cc18f74650253f8) Reafctor more functions ### 📊 Changes **12 files changed** (+483 additions, -364 deletions) <details> <summary>View changed files</summary> 📝 `ESP32_AP-Flasher/include/contentmanager.h` (+12 -12) 📝 `ESP32_AP-Flasher/include/newproto.h` (+8 -8) 📝 `ESP32_AP-Flasher/include/tag_db.h` (+6 -7) ➕ `ESP32_AP-Flasher/include/util.h` (+102 -0) 📝 `ESP32_AP-Flasher/include/web.h` (+2 -2) 📝 `ESP32_AP-Flasher/src/contentmanager.cpp` (+298 -279) 📝 `ESP32_AP-Flasher/src/main.cpp` (+14 -13) 📝 `ESP32_AP-Flasher/src/makeimage.cpp` (+4 -3) 📝 `ESP32_AP-Flasher/src/newproto.cpp` (+20 -20) 📝 `ESP32_AP-Flasher/src/ota.cpp` (+4 -8) 📝 `ESP32_AP-Flasher/src/tag_db.cpp` (+8 -8) 📝 `ESP32_AP-Flasher/src/web.cpp` (+5 -4) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
sascha_hemi added the pull-request label 2026-03-20 23:08:02 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/OpenEPaperLink#3732