mirror of
https://github.com/OpenEPaperLink/OpenEPaperLink.git
synced 2026-03-21 00:04:28 +01:00
[PR #337] [MERGED] Bugfix: Update variable minutesUntilNextUpdate to 32-bit integer because of integer overflow #500
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/OpenEPaperLink/OpenEPaperLink/pull/337
Author: @mnyhlen
Created: 6/12/2024
Status: ✅ Merged
Merged: 6/15/2024
Merged by: @skiphansen
Base:
master← Head:bugfix_calculating_nextcheckin📝 Commits (1)
6981171Bugfix: Update variable minutesUntilNextUpdate to 32-bit integer because of integer overflow📊 Changes
1 file changed (+1 additions, -1 deletions)
View changed files
📝
ESP32_AP-Flasher/src/contentmanager.cpp(+1 -1)📄 Description
At time of writing this, when a tag is idle, it will check in once every minute regardless of what you have set your "Maximum sleep" to. This happens because the result of calculating minutesUntilNextUpdate will be a negative number and prepareIdleReq will never be executed. On (Wed Jul 03 2024 00:33:00 GMT+0000) tags will idle as it should again when the calculated value will be a positive number and will work as it is supposed to for approximately ~22,75 days when it will become a negative number again.
Changing the variable to 32-bit instead of 16-bit will resolve this "interval bug".
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.