[PR #132] [MERGED] Add custom tag data parser #979

New Issue

sascha_hemi · 2026-03-20T18:14:42+01:00

sascha_hemi commented

2026-03-20 18:14:42 +01:00

📋 Pull Request Information

Original PR: https://github.com/OpenEPaperLink/OpenEPaperLink/pull/132
Author: @enwi
Created: 9/16/2023
Status: ✅ Merged
Merged: 9/26/2023
Merged by: @nlimper

Base: master ← Head: tag_data

📝 Commits (9)

2a6bcc6 Add formatString convenience function
9f855ae Use String& for wsLog, wsErr and wsSerial
8f8da66 Add tag data parser and parse tag data
83e4b67 Make logLine use String&
12c9d5b Fix issue with formatString
9edde4b Reuse payloadLength in processTagReturnData
e7de9d4 Fix parsing of unsigned/signed inetegers and cleanup
6bc2b01 Use c++17 standard
673a3bd Cleanup logging

📊 Changes

10 files changed (+363 additions, -31 deletions)

View changed files

📝 ESP32_AP-Flasher/include/system.h (+1 -1)
➕ ESP32_AP-Flasher/include/tagdata.h (+140 -0)
📝 ESP32_AP-Flasher/include/util.h (+16 -1)
📝 ESP32_AP-Flasher/include/web.h (+3 -3)
📝 ESP32_AP-Flasher/platformio.ini (+44 -17)
📝 ESP32_AP-Flasher/src/main.cpp (+2 -0)
📝 ESP32_AP-Flasher/src/newproto.cpp (+7 -5)
📝 ESP32_AP-Flasher/src/system.cpp (+1 -1)
➕ ESP32_AP-Flasher/src/tagdata.cpp (+146 -0)
📝 ESP32_AP-Flasher/src/web.cpp (+3 -3)

📄 Description

Add custom tag data parser
Improve system.h logLine
Improve web.h wsLog, wsErr and wsSerial

Open for discussion:

Print log to serial or web serial?
Currently log is printed to both:

sprintf(buffer, ...);
wsLog((String)buffer);
Serial.printf(...);

Implementation uses std::optional, which needs at least c++17, can we bump c++ standard to 17?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OpenEPaperLink/OpenEPaperLink/pull/132 **Author:** [@enwi](https://github.com/enwi) **Created:** 9/16/2023 **Status:** ✅ Merged **Merged:** 9/26/2023 **Merged by:** [@nlimper](https://github.com/nlimper) **Base:** `master` ← **Head:** `tag_data` --- ### 📝 Commits (9) - [`2a6bcc6`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/2a6bcc67d58c3b6bbbca99c5d1f9fb0773414988) Add formatString convenience function - [`9f855ae`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/9f855ae1d0ef2fcc1fc1f5a00f524337ebe1594f) Use String& for wsLog, wsErr and wsSerial - [`8f8da66`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/8f8da66978d954bfd2bfdb4682b5a30423ee1845) Add tag data parser and parse tag data - [`83e4b67`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/83e4b6725e722242385214d85f1c0392cba1e19a) Make logLine use String& - [`12c9d5b`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/12c9d5bb56e813f0d4c141b4efd0c10c98edf438) Fix issue with formatString - [`9edde4b`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/9edde4b56179a57cca7ca6149f9a179aaebcc438) Reuse payloadLength in processTagReturnData - [`e7de9d4`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/e7de9d4e3ac06c471c3cead6dddba1a17efe60f6) Fix parsing of unsigned/signed inetegers and cleanup - [`6bc2b01`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/6bc2b016988a1196a8e275829836139d37a60034) Use c++17 standard - [`673a3bd`](https://github.com/OpenEPaperLink/OpenEPaperLink/commit/673a3bdadb7322ffa5e16657a02f0749de9caf50) Cleanup logging ### 📊 Changes **10 files changed** (+363 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `ESP32_AP-Flasher/include/system.h` (+1 -1) ➕ `ESP32_AP-Flasher/include/tagdata.h` (+140 -0) 📝 `ESP32_AP-Flasher/include/util.h` (+16 -1) 📝 `ESP32_AP-Flasher/include/web.h` (+3 -3) 📝 `ESP32_AP-Flasher/platformio.ini` (+44 -17) 📝 `ESP32_AP-Flasher/src/main.cpp` (+2 -0) 📝 `ESP32_AP-Flasher/src/newproto.cpp` (+7 -5) 📝 `ESP32_AP-Flasher/src/system.cpp` (+1 -1) ➕ `ESP32_AP-Flasher/src/tagdata.cpp` (+146 -0) 📝 `ESP32_AP-Flasher/src/web.cpp` (+3 -3) </details> ### 📄 Description - Add custom tag data parser - Improve system.h `logLine` - Improve web.h `wsLog`, `wsErr` and `wsSerial` Open for discussion: - Print log to serial or web serial? Currently log is printed to both: ```c++ sprintf(buffer, ...); wsLog((String)buffer); Serial.printf(...); ``` - Implementation uses `std::optional`, which needs at least c++17, can we bump c++ standard to 17? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

sascha_hemi added the pull-request label 2026-03-20 18:14:42 +01:00

sascha_hemi closed this issue

2026-03-20 18:14:42 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/OpenEPaperLink#979