Electric-Special/ha-core
1
0
Fork 0
mirror of https://github.com/Electric-Special/ha-core.git synced 2026-03-21 07:05:48 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix flaky fritz update tests caused by class attribute pollution in test fixtures (#163169)

Browse Source
This commit is contained in:
Franck Nijhof
2026-02-16 15:25:08 +01:00
committed by GitHub
parent 6e48172654
commit 8a5d5a8468
1 changed files with 42 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

64
tests/components/fritz/conftest.py
View File

@@ -105,32 +105,52 @@ def fc_class_mock(fc_data):
@pytest.fixture
def fh_class_mock():
"""Fixture that sets up a mocked FritzHosts class."""
with patch(
"homeassistant.components.fritz.coordinator.FritzHosts",
new=FritzHosts,
) as result:
result.get_mesh_topology = MagicMock(return_value=MOCK_MESH_DATA)
result.get_hosts_attributes = MagicMock(return_value=MOCK_HOST_ATTRIBUTES_DATA)
with (
patch(
"homeassistant.components.fritz.coordinator.FritzHosts",
new=FritzHosts,
) as result,
patch.object(
FritzHosts,
"get_mesh_topology",
MagicMock(return_value=MOCK_MESH_DATA),
),
patch.object(
FritzHosts,
"get_hosts_attributes",
MagicMock(return_value=MOCK_HOST_ATTRIBUTES_DATA),
),
):
yield result
@pytest.fixture
def fs_class_mock():
"""Fixture that sets up a mocked FritzStatus class."""
with patch(
"homeassistant.components.fritz.coordinator.FritzStatus",
new=FritzStatus,
) as result:
result.get_default_connection_service = MagicMock(
return_value=MOCK_STATUS_CONNECTION_DATA
)
result.get_device_info = MagicMock(
return_value=ArgumentNamespace(MOCK_STATUS_DEVICE_INFO_DATA)
)
result.get_monitor_data = MagicMock(return_value={})
result.get_cpu_temperatures = MagicMock(return_value=[42, 38])
result.get_avm_device_log = MagicMock(
return_value=MOCK_STATUS_AVM_DEVICE_LOG_DATA
)
result.has_wan_enabled = True
with (
patch(
"homeassistant.components.fritz.coordinator.FritzStatus",
new=FritzStatus,
) as result,
patch.object(
FritzStatus,
"get_default_connection_service",
MagicMock(return_value=MOCK_STATUS_CONNECTION_DATA),
),
patch.object(
FritzStatus,
"get_device_info",
MagicMock(return_value=ArgumentNamespace(MOCK_STATUS_DEVICE_INFO_DATA)),
),
patch.object(FritzStatus, "get_monitor_data", MagicMock(return_value={})),
patch.object(
FritzStatus, "get_cpu_temperatures", MagicMock(return_value=[42, 38])
),
patch.object(
FritzStatus,
"get_avm_device_log",
MagicMock(return_value=MOCK_STATUS_AVM_DEVICE_LOG_DATA),
),
patch.object(FritzStatus, "has_wan_enabled", True),
):
yield result