Electric-Special/ha-core
1
0
Fork 0
mirror of https://github.com/Electric-Special/ha-core.git synced 2026-03-21 05:06:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add full debug logs for coordinator failures (#163228)

Browse Source
This commit is contained in:
Josef Zweck
2026-02-17 09:52:44 +01:00
committed by GitHub
parent e4c7262260
commit cda6236099
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
homeassistant/helpers/update_coordinator.py
View File

@@ -420,6 +420,7 @@ class DataUpdateCoordinator(BaseDataUpdateCoordinatorProtocol, Generic[_DataT]):
if self.last_update_success:
if log_failures:
self.logger.error("Timeout fetching %s data", self.name)
self.logger.debug("Full error:", exc_info=True)
self.last_update_success = False
except (aiohttp.ClientError, requests.exceptions.RequestException) as err:
@@ -427,6 +428,7 @@ class DataUpdateCoordinator(BaseDataUpdateCoordinatorProtocol, Generic[_DataT]):
if self.last_update_success:
if log_failures:
self.logger.error("Error requesting %s data: %s", self.name, err)
self.logger.debug("Full error:", exc_info=True)
self.last_update_success = False
except urllib.error.URLError as err:
@@ -439,6 +441,7 @@ class DataUpdateCoordinator(BaseDataUpdateCoordinatorProtocol, Generic[_DataT]):
self.logger.error(
"Error requesting %s data: %s", self.name, err
)
self.logger.debug("Full error:", exc_info=True)
self.last_update_success = False
except UpdateFailed as err:
@@ -456,6 +459,7 @@ class DataUpdateCoordinator(BaseDataUpdateCoordinatorProtocol, Generic[_DataT]):
if self.last_update_success:
if log_failures:
self.logger.error("Error fetching %s data: %s", self.name, err)
self.logger.debug("Full error:", exc_info=True)
self.last_update_success = False
except ConfigEntryError as err:
@@ -467,6 +471,7 @@ class DataUpdateCoordinator(BaseDataUpdateCoordinatorProtocol, Generic[_DataT]):
self.name,
err,
)
self.logger.debug("Full error:", exc_info=True)
self.last_update_success = False
if raise_on_entry_error:
raise
@@ -481,6 +486,7 @@ class DataUpdateCoordinator(BaseDataUpdateCoordinatorProtocol, Generic[_DataT]):
self.name,
err,
)
self.logger.debug("Full error:", exc_info=True)
self.last_update_success = False
if raise_on_auth_failed:
raise

2
tests/components/ambient_network/test_sensor.py
View File

@@ -82,7 +82,7 @@ async def test_sensors_disappearing(
sensor = hass.states.get("sensor.station_a_relative_pressure")
assert sensor is not None
assert sensor.state == "unavailable"
assert caplog.text.count("Cannot connect to Ambient Network") == 1
assert caplog.text.count("Cannot connect to Ambient Network") == 3
# Network comes back. Sensor should start reporting again. Log message
# should only show up once.